Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8293362

Extend detection of modified nodes to incremental inlining

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: P4 P4
    • tbd
    • 20
    • hotspot

      In JDK-8255670 we extended the assertion code to include all modifications to nodes, and check that they are processed in igvn.

      So far, incremental inlining is explicitly excluded from this check. The goal is to include it.

      I tried this before, and got a lot of failure cases, with all sorts of nodes. If I remember correctly, we use GraphKit to generate new nodes during regular parsing, but also during late/incremental inlining. But somehow they now only trigger the assert in the late/incremental inlining case. It cannot be that in all those cases we explicitly add the node to igvn worklist, so you need to find another solution that is more general.

            epeter Emanuel Peter
            epeter Emanuel Peter
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: