Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8293438

testing.md lacks information on running gtests

XMLWordPrintable

      The following information took me too long to discover, because it was not present in `doc/testing.md`. Note that the jtreg instructions are workable; it's just the gtest part that is lacking.

      Please also consider adding links (somewhere) to jtreg and googletest downloads. I know jib.sh does this for some of us, but the instructions should not silently assume everyone is a jib user.

      ```
      diff --git a/doc/testing.md b/doc/testing.md
      index b8b4971cef8..2515004a033 100644
      --- a/doc/testing.md
      +++ b/doc/testing.md
      @@ -167,6 +167,10 @@ use a fully qualified test descriptor, add `jtreg:`, e.g.
       
       ### Gtest
       
      +To be able to run Google-style tests, `configure` may need help
      +finding the googletest test framework. See `doc/building.md` for
      +information.
      +
       Since the Hotspot Gtest suite is so quick, the default is to run all tests.
       This is specified by just `gtest`, or as a fully qualified test descriptor
       `gtest:all`.
      ```

            Unassigned Unassigned
            jrose John Rose
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: