Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8293815

P11PSSSignature.engineUpdate should not print debug messages during normal operation

    XMLWordPrintable

Details

    Backports

      Description

        During testing I have found messages such as this are printed to stdout:
        sun.security.pkcs11.P11PSSSignature@6e1567f1: Calling C_SignUpdate

        Problem:
        Problem is in P11PSSSignature.engineUpdate method [1], which unconditionally prints some debug information to stdout. Other prints in that class are conditional based on value of DEBUG field.

        Solution:
        I have made fix to make these conditional based on value of DEBUG field. As it only affects debug messages, there is no test added.

        Testing:
        Passed jdk_security locally with my fix.

        [1] https://github.com/openjdk/jdk/blob/211fab8d361822bbd1a34a88626853bf4a029af5/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11PSSSignature.java#L578

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8297576 P11PSSSignature.engineUpdate should not print debug messages during normal operation

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8303954 P11PSSSignature.engineUpdate should not print debug messages during normal operation

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8304166 P11PSSSignature.engineUpdate should not print debug messages during normal operation

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk8u-dev/a7fb08c2

            Commit Commit openjdk/jdk11u-dev/80615a6f

            Commit Commit openjdk/jdk17u-dev/17438250

            Commit Commit openjdk/jdk/2057070e

            Review Review openjdk/jdk8u-dev/283

            Review Review openjdk/jdk11u-dev/1782

            Review Review openjdk/jdk17u-dev/708

            Review Review openjdk/jdk/10270

            Activity

              People

                valeriep Valerie Peng
                zzambers Zdenek Zambersky
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: