Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8294270

make test passes awkward -status:-status:error,fail to jtreg

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P4
    • 20
    • 11, 17, 18, 19, 20
    • infrastructure
    • None
    • b17

    Description

      JDK-8230067 added jtreg retries, but it does so awkwardly: it sets `export JTREG_STATUS="-status:error,fail";` on retry, and then uses it as `-status:$$$${JTREG_STATUS}`.

      Which means we end up passing either: `-status:` or `-status:-status:error,fail` to jtreg. I confirmed this by also instrumenting the local jtreg build.

      Now, it is not a problem for current jtreg, because it checks the status codes awkwardly with `String.contains`:
      https://github.com/openjdk/jtreg/blob/aeb552e6df73e039e20de59b3ec847f36ab6e202/src/share/classes/com/sun/javatest/regtest/tool/Tool.java#L1635-L1640

      But it will be a problem if jtreg ever starts to validate the arguments properly. I propose we fix this in current build system.

      Attachments

        Issue Links

          Activity

            People

              shade Aleksey Shipilev
              shade Aleksey Shipilev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: