Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8294538

missing is_unloading() check in SharedRuntime::fixup_callers_callsite()

    XMLWordPrintable

Details

    • b21

    Backports

      Description

        From JDK-8293648, Erik Österlund wrote:

        I also noticed that SharedRuntime::fixup_callers_callsite() patches callsites if the c2i adapter's Method's code is is_in_use(). It seems to miss an "&& !is_unloading()" in there. In practice that has not made a big difference until I removed the sweeper. Because nmethods would typically be is_unloading, because the Method is also unloading, in which case the c2i adapter entry barrier will take care of it. But now that an nmethod can become is_unloading also because it's "cold" or such, its Method is way more likely to be is_alive. And then we can get past the c2i adapter entry barrier, and end up calling fixup_callers_callsite, and miss the is_unloading check on the code, and break unlinking monotonicity of the inline cache cleaning. That could have pretty disasterous consequences when using ZGC.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8299583 missing is_unloading() check in SharedRuntime::fixup_callers_callsite()

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8296278 missing is_unloading() check in SharedRuntime::fixup_callers_callsite()

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8297512 missing is_unloading() check in SharedRuntime::fixup_callers_callsite()

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8293648 Kitchensink.java failed with SIGSEGV in compiled frame with ZGC

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. JDK-8295097 DirectNativeCallWrapper::verify_resolve_call fails with "assert(db != __null && !db->is_adapter_blob()) failed: must use stub!"

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. JDK-8291832 RenaissanceStressTest24H.java fails with "fatal error: missing receiver type check"

            • P3 - Major loss of function.
            • Closed
            links to

            Commit Commit openjdk/jdk17u-dev/013709f6

            Commit Commit openjdk/jdk19u/d1268e96

            Commit Commit openjdk/jdk/b5efa2af

            Review Review openjdk/jdk17u-dev/1021

            Review Review openjdk/jdk19u/81

            Review Review openjdk/jdk/10747

            Activity

              People

                dlong Dean Long
                dlong Dean Long
                Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: