Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8295210

IR framework should not whitelist -XX:-UseTLAB

XMLWordPrintable

    • b04

        The IR framework currently whitelists UseTLAB and as a result, IR verification is enabled even if TLAB allocations are disabled which can lead to failures (because the IR differs).

        Since JDK-8310187, test/hotspot/jtreg/compiler/gcbarriers/TestZGCBarrierElision.java fails in compiler stress testing (stress-comp-no-tlab) with -XX:-UseTLAB:

        Failed IR Rules (4) of Methods (4)
        ----------------------------------
        1) Method "static void compiler.gcbarriers.TestZGCEffectiveBarrierElision.testAllocateArrayThenStoreAtKnownIndex(compiler.gcbarriers.Outer)" - [Failed IR rules: 1]:
           * @IR rule 1: "@compiler.lib.ir_framework.IR(applyIfCPUFeatureAnd={}, phase={FINAL_CODE}, applyIf={}, applyIfCPUFeatureOr={}, applyIfCPUFeature={}, counts={"_#C#Z_STORE_P_WITH_BARRIER_FLAG#_", "elided", "1"}, failOn={}, applyIfAnd={}, applyIfOr={}, applyIfNot={})"
             > Phase "Final Code":
               - counts: Graph contains wrong number of nodes:
                 * Constraint 1: "(\\d+(\\s){2}(zStoreP\\S*.*)+(\\s){2}===.*barrier\\(\\s*elided\\s*\\))"
                   - Failed comparison: [found] 0 = 1 [given]
                   - No nodes matched!

        [...]

              enothum Eric Nothum (Inactive)
              thartmann Tobias Hartmann
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: