Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8295268

Optimized builds are broken due to incorrect assert_is_rfp shortcuts

    XMLWordPrintable

Details

    • b20

    Backports

      Description

        Fails on many platforms, for example arm32:

        ```
        /home/shade/trunks/jdk/src/hotspot/cpu/arm/smallRegisterMap_arm.inline.hpp:36:36: error: expected ';' at end of member declaration
           36 | static void assert_is_rfp(VMReg r) PRODUCT_RETURN
              | ^
        ```

        The reason is that `PRODUCT_RETURN` + `DEBUG_ONLY` are not unity: in "optimized" builds, we have `!PRODUCT` and `!DEBUG`.

        ```
          static void assert_is_rfp(VMReg r) PRODUCT_RETURN
                                             DEBUG_ONLY({ Unimplemented(); })
        ```

        Attachments

          Issue Links

            Activity

              People

                shade Aleksey Shipilev
                shade Aleksey Shipilev
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: