-
Bug
-
Resolution: Fixed
-
P4
-
19, 20
-
b20
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8295904 | 19.0.2 | Aleksey Shipilev | P4 | Resolved | Fixed | b03 |
Fails on many platforms, for example arm32:
```
/home/shade/trunks/jdk/src/hotspot/cpu/arm/smallRegisterMap_arm.inline.hpp:36:36: error: expected ';' at end of member declaration
36 | static void assert_is_rfp(VMReg r) PRODUCT_RETURN
| ^
```
The reason is that `PRODUCT_RETURN` + `DEBUG_ONLY` are not unity: in "optimized" builds, we have `!PRODUCT` and `!DEBUG`.
```
static void assert_is_rfp(VMReg r) PRODUCT_RETURN
DEBUG_ONLY({ Unimplemented(); })
```
```
/home/shade/trunks/jdk/src/hotspot/cpu/arm/smallRegisterMap_arm.inline.hpp:36:36: error: expected ';' at end of member declaration
36 | static void assert_is_rfp(VMReg r) PRODUCT_RETURN
| ^
```
The reason is that `PRODUCT_RETURN` + `DEBUG_ONLY` are not unity: in "optimized" builds, we have `!PRODUCT` and `!DEBUG`.
```
static void assert_is_rfp(VMReg r) PRODUCT_RETURN
DEBUG_ONLY({ Unimplemented(); })
```
- backported by
-
JDK-8295904 Optimized builds are broken due to incorrect assert_is_rfp shortcuts
- Resolved
- relates to
-
JDK-8284161 Implementation of Virtual Threads (Preview)
- Resolved
- links to
-
Commit openjdk/jdk19u/53f6f0b9
-
Commit openjdk/jdk/e7a964b4
-
Review openjdk/jdk19u/50
-
Review openjdk/jdk/10696
(1 links to)