Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8295531

ComboBoxBaseSkin: memory leak when changing skin

    XMLWordPrintable

Details

    • b11

    Description

      as determined by SkinMemoryLeakTest (remove line 166) and a leak tester
      https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java

      Affected skins:
      - ColorPicker
      - DatePicker
      - ComboBox

      caused by:
      - out-of-order modification of the control property (skin.install)
      - adding skin nodes and not removing them in dispose()
      - adding listeners and not removing them in dispose()

      NOTE: the fix will require not only ListenerHelper JDK-8294809 but also Skin.install() JDK-8290844 changes.

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. JDK-8241364 ☂ Cleanup skin implementations to allow switching

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open
          is blocked by

          Enhancement - null JDK-8290844 Add Skin.install() method

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8294809 ListenerHelper for managing and disconnecting listeners

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8087680 DatePicker doesn't give to instantiate skin object for existing control

          • P5 - Cosmetic problem like misspelt words or misaligned text.
          • Open
          links to

          Commit Commit openjdk/jfx/bb139208

          Review Review openjdk/jfx/922

          Activity

            People

              angorya Andy Goryachev
              angorya Andy Goryachev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: