Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8295754

PaginationSkin: memory leak when changing skin

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3
    • jfx20
    • None
    • javafx
    • b10

    Description

      as determined by SkinMemoryLeakTest (remove line 171) and a leak tester
      https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java

      Make sure to configure the current test in LeakTest:
      protected final Type WE_ARE_TESTING = Type.PAGINATION;

      Found another issue: Pagination class does not survive replacing its skin (all components disappear).

      caused by:
      - adding and not removing listeners
      - adding and not removing children Nodes
      - setting control's properties in the constructor
      - incorrectly setting a clip rectangle

      NOTE: the fix requires both ListenerHelper JDK-8294809 and Skin.install() JDK-8290844 changes.

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. JDK-8241364 ☂ Cleanup skin implementations to allow switching

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open
          relates to

          Enhancement - null JDK-8290844 Add Skin.install() method

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8294809 ListenerHelper for managing and disconnecting listeners

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8088490 Pagination control disappears, when skin is replaced

          • P5 - Cosmetic problem like misspelt words or misaligned text.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JDK-8301797 Pagination control has the wrong size

          • P2 - Crashes, loss of data, severe memory leak.
          • Resolved
          links to

          Commit Commit openjdk/jfx/0a785ae0

          Review Review openjdk/jfx/925

          Activity

            People

              angorya Andy Goryachev
              angorya Andy Goryachev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: