Description
as determined by SkinMemoryLeakTest (remove line 171) and a leak tester
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
Make sure to configure the current test in LeakTest:
protected final Type WE_ARE_TESTING = Type.PAGINATION;
Found another issue: Pagination class does not survive replacing its skin (all components disappear).
caused by:
- adding and not removing listeners
- adding and not removing children Nodes
- setting control's properties in the constructor
- incorrectly setting a clip rectangle
NOTE: the fix requires both ListenerHelperJDK-8294809 and Skin.install() JDK-8290844 changes.
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
Make sure to configure the current test in LeakTest:
protected final Type WE_ARE_TESTING = Type.PAGINATION;
Found another issue: Pagination class does not survive replacing its skin (all components disappear).
caused by:
- adding and not removing listeners
- adding and not removing children Nodes
- setting control's properties in the constructor
- incorrectly setting a clip rectangle
NOTE: the fix requires both ListenerHelper
Attachments
Issue Links
- blocks
-
JDK-8241364 ☂ Cleanup skin implementations to allow switching
-
- Open
-
- relates to
-
JDK-8290844 Add Skin.install() method
-
- Resolved
-
-
JDK-8294809 ListenerHelper for managing and disconnecting listeners
-
- Resolved
-
-
JDK-8088490 Pagination control disappears, when skin is replaced
-
- Open
-
-
JDK-8301797 Pagination control has the wrong size
-
- Resolved
-
(2 links to)