Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8295809

TreeTableViewSkin: memory leak when changing skin

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3
    • jfx20
    • None
    • javafx
    • b11

    Description

      as determined by SkinMemoryLeakTest (remove line 180) and a leak tester
      https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java

      caused by:
      - adding and not removing listeners
      - adding and not removing event handlers/filters
      - adding and not removing cell factory
      - holding unnecessary instance in TreeTableViewSkin.treeTableViewSkin // test-only

      NOTES:
      1. this fix requires JDK-8294809 ListenerHelper and JDK-8295806 TableViewSkin.
      2. there were more memory leaks in this skin than detected by SkinMemoryLeakTest, probably because of cell factory (?). A manual test using LeakTest shows that there are no memory leaks after a) replacing skin, b) moving the components to a new window, and c) removing all the components from the window.

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. JDK-8241364 ☂ Cleanup skin implementations to allow switching

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8295806 TableViewSkin: memory leak when changing skin

          • P3 - Major loss of function.
          • Resolved

          Enhancement - null JDK-8294809 ListenerHelper for managing and disconnecting listeners

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8307538 Memory leak in TreeTableView when calling refresh

          • P2 - Crashes, loss of data, severe memory leak.
          • Resolved
          links to

          Commit Commit openjdk/jfx/6abbe080

          Review Review openjdk/jfx/931

          Activity

            People

              angorya Andy Goryachev
              angorya Andy Goryachev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: