Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8296136

Use correct register in aarch64_enc_fast_unlock()

    XMLWordPrintable

Details

    • b22
    • aarch64
    • generic

    Backports

      Description

        In aarch64_enc_fast_unlock() (aarch64.ad) we have this piece of code:

            __ ldr(tmp, Address(oop, oopDesc::mark_offset_in_bytes()));
            __ tbnz(disp_hdr, exact_log2(markWord::monitor_value), object_has_monitor);

        The tbnz uses the wrong register - it should really use tmp. disp_hdr has been loaded with the displaced header of the stack-lock, which would never have its monitor bits set, thus the branch will always take the slow path. In the case of !UseHeavyMonitors it is even worse, then disp_hdr will be unitialized.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8296664 Use correct register in aarch64_enc_fast_unlock()

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8299469 Use correct register in aarch64_enc_fast_unlock()

            • P3 - Major loss of function.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8305006 Use correct register in riscv_enc_fast_unlock()

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk17u-dev/9a2743f6

            Commit Commit openjdk/jdk/7619602c

            Review Review openjdk/jdk17u-dev/1005

            Review Review openjdk/jdk/10921

            Activity

              People

                rkennke Roman Kennke
                rkennke Roman Kennke
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: