Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8296157

Rename FileMapInfo::space_at() to region_at()

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 20
    • 20
    • hotspot
    • b23

    Description

      Most of the CDS code refers to a memory blocks inside a CDS file as "regions", represented by the type FileMapRegion.

      We have this legacy API:

        FileMapRegion* FileMapInfo::space_at(int i)

      which looks awkward:

        FileMapRegion* si = space_at(MetaspaceShared::bm);
        if (si->mapped_base() != NULL) {
          return si->mapped_base();
        }

      =====================

      Proposal:

      rename API to

      FileMapRegion* FileMapInfo::region_at(int i)

      Change the relevant code to

        FileMapRegion* r = space_at(MetaspaceShared::bm);
        if (r->mapped_base() != NULL) {
          return r->mapped_base();
        }

      Attachments

        Issue Links

          Activity

            People

              matsaave Matias Saavedra Silva
              iklam Ioi Lam
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: