Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8296208

AArch64: Enable SHA512 intrinsic by default on supported hardware

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 20
    • 20
    • hotspot
    • b26
    • aarch64

    Description

      As commented in https://bugs.openjdk.org/browse/JDK-8293484?focusedCommentId=14532743&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14532743, we may like to set sha512 intrinsic enabled by default on CPU cores, where sha512 feature is supported.

      Here shows the snippet of the comment in JDK-8293484
      ```
      Besides, I noticed that this case(TestUseSHA512IntrinsicsOptionOnSupportedCPU.java) failed on Graviton3 with the JDK mainline code base either.
      Here shows the snippet of error log.

      ```
      TEST RESULT: Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Option 'UseSHA512Intrinsics' is expected to have 'true' value Option 'UseSHA512Intrinsics' should be enabled by default
      --------------------------------------------------
      Test results: failed: 1
      ```

      I think the root cause (for the failure with mainline code base) is that SHA512 intrinsics is disabled even
      with the sha512 feature supported hardware, mainly because there was no available hardware for testing when implementing SHA512 intrinsincs.
      See the comment around https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/vm_version_aarch64.cpp#L348~L351
      ```

      Attachments

        Issue Links

          Activity

            People

              haosun Hao Sun (Inactive)
              haosun Hao Sun (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: