Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8296243

[IR Framework] Fix issues with IRNode.ALLOC* regexes

    XMLWordPrintable

Details

    • b24
    • ppc

    Description

      There are two problems with IRNode.ALLOC* regexes:
      - On PPC64, we do not account for an LI instruction which matches the array size. As a result, we could miss some array allocations with the ALLOC_ARRAY regexes
      - The new IRNode.ALLOC regex which can be matched on the independent ideal phases by using the name of the IR node "Allocate" also matches "AllocateArray". This should be changed.

      Original report:

      Since JDK-8280378, the test testlibrary_tests/ir_framework/tests/TestPhaseIRMatching.java reports:
      "Expected Failures" WITHOUT "Found Failures":
      Failure[methodName=alloc, irRuleId=1, compilePhase=PRINT_OPTO_ASSEMBLY, checkAttributeType=FAIL_ON, constraintId=2]
      Failure[methodName=alloc, irRuleId=1, compilePhase=PRINT_OPTO_ASSEMBLY, checkAttributeType=COUNTS, constraintId=2]
      "Found Failures" WITHOUT "Expected Failures":
      []

      Attachments

        Issue Links

          Activity

            People

              chagedorn Christian Hagedorn
              mdoerr Martin Doerr
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: