Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8298568

Fastdebug build fails after JDK-8296389

XMLWordPrintable

    • b02
    • generic
    • generic

        Compiling up to 330 files for java.management
        Updating support/src.zip
        Updating support/modules_libs/java.base/server/libjvm.so due to 8 file(s)
        /home/realfyang/openjdk-jdk/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp: In function 'bool has_never_branch(Node*)':
        /home/realfyang/openjdk-jdk/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:2005:92: error: 'class Node' has no member named 'isNeverBranch'; did you mean 'is_NeverBranch'?
         2005 | if (in != NULL && in->Opcode() == Op_Halt && in->in(0)->is_Proj() && in->in(0)->in(0)->isNeverBranch()) {
              | ^~~~~~~~~~~~~
              | is_NeverBranch
        make[3]: *** [lib/CompileJvm.gmk:147: /home/realfyang/openjdk-jdk/build/linux-aarch64-server-slowdebug/hotspot/variant-server/libjvm/objs/shenandoahSupport.o] Error 1
        make[3]: *** Waiting for unfinished jobs....
        make[2]: *** [make/Main.gmk:252: hotspot-server-libs] Error 2

        ERROR: Build failed for target 'images' in configuration 'linux-aarch64-server-slowdebug' (exit code 2)
        Stopping javac server

        === Output from failing command(s) repeated here ===
        * For target hotspot_variant-server_libjvm_objs_shenandoahSupport.o:
        /home/realfyang/openjdk-jdk/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp: In function 'bool has_never_branch(Node*)':
        /home/realfyang/openjdk-jdk/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:2005:92: error: 'class Node' has no member named 'isNeverBranch'; did you mean 'is_NeverBranch'?
         2005 | if (in != NULL && in->Opcode() == Op_Halt && in->in(0)->is_Proj() && in->in(0)->in(0)->isNeverBranch()) {
              | ^~~~~~~~~~~~~
              | is_NeverBranch

        * All command lines available in /home/realfyang/openjdk-jdk/build/linux-aarch64-server-slowdebug/make-support/failure-logs.
        === End of repeated output ===

        No indication of failed target found.
        HELP: Try searching the build log for '] Error'.
        HELP: Run 'make doctor' to diagnose build problems.

        make[1]: *** [/home/realfyang/openjdk-jdk/make/Init.gmk:320: main] Error 2
        make: *** [/home/realfyang/openjdk-jdk/make/Init.gmk:186: images] Error 2

        Proposed fix is trivial:
        diff --git a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
        index 31c480a488a..d443bb8aa33 100644
        --- a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
        +++ b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
        @@ -2002,7 +2002,7 @@ Node* ShenandoahIUBarrierNode::Identity(PhaseGVN* phase) {
         static bool has_never_branch(Node* root) {
           for (uint i = 1; i < root->req(); i++) {
             Node* in = root->in(i);
        - if (in != NULL && in->Opcode() == Op_Halt && in->in(0)->is_Proj() && in->in(0)->in(0)->isNeverBranch()) {
        + if (in != NULL && in->Opcode() == Op_Halt && in->in(0)->is_Proj() && in->in(0)->in(0)->is_NeverBranch()) {
               return true;
             }
           }

              fyang Fei Yang
              fyang Fei Yang
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: