Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8298588

WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

    XMLWordPrintable

Details

    • b03
    • generic
    • generic

    Backports

      Description

        According to rfc6455[1], the close frame MAY contain a body, i.e. it is considered optional. Although, due to JDK-8240666, in most recent JDKs the request body is being populated. HandshakeUrlEncodingTest.java introduced with JDK-8245245 relies on the fact that a body is being populated and parses its contents.

        However, older JDKs (e.g. JDK 11) do not populate the body and the test wrongly fails for that reason. It would be better to model the test according to the optional nature of a content body being present or not, without sacrificing assertions the test was meant to do (verify a fix of JDK-8245245 is present).

        [1] https://www.rfc-editor.org/rfc/rfc6455.html#section-5.5.1

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8299195 WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8299262 WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8299382 WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

            • P3 - Major loss of function.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/ce106888

            Commit Commit openjdk/jdk17u-dev/d973531c

            Commit Commit openjdk/jdk20/92fe304f

            Commit Commit openjdk/jdk/909d0cb4

            Review Review openjdk/jdk11u-dev/1558

            Review Review openjdk/jdk17u-dev/958

            Review Review openjdk/jdk20/63

            Review Review openjdk/jdk/11486

            Activity

              People

                sgehwolf Severin Gehwolf
                sgehwolf Severin Gehwolf
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: