Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8298957 | 21 | Jan Lahoda | P3 | Resolved | Fixed | b03 |
Running this test:
```
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* @test
* @bug 9999999
* @summary XXX
* @library /tools/lib
* @modules jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.main
* @build toolbox.TestRunner toolbox.ToolBox EmptyPackageInfo
* @run main EmptyPackageInfo
*/
import com.sun.source.tree.Tree;
import com.sun.source.util.JavacTask;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import com.sun.source.util.Trees;
import javax.tools.ToolProvider;
import toolbox.TestRunner;
import toolbox.TestRunner.Test;
import toolbox.ToolBox;
public class EmptyPackageInfo extends TestRunner {
public static void main(String... args) throws Exception {
new EmptyPackageInfo().runTests(m -> new Object[] { Paths.get(m.getName()) });
}
private final ToolBox tb = new ToolBox();
public EmptyPackageInfo() {
super(System.err);
}
@Test
public void testEmptyPackageInfo(Path outerBase) throws Exception {
Path src = outerBase.resolve("src");
Path classes = outerBase.resolve("classes");
Path packInfo = src.resolve("package-info.java");
tb.writeFile(packInfo, "/**javadoc*/\n");
Files.createDirectories(classes);
var compiler = ToolProvider.getSystemJavaCompiler();
try (var fm = compiler.getStandardFileManager(null,
null,
null)) {
var task =
(JavacTask) compiler.getTask(null,
fm,
null,
null,
null,
fm.getJavaFileObjects(packInfo));
task.analyze();
var pack = task.getElements().getPackageElement("");
var trees = Trees.instance(task);
var packPath = trees.getPath(pack);
var packTree = packPath.getLeaf();
if (packTree.getKind() != Tree.Kind.COMPILATION_UNIT) {
throw new AssertionError("Unexpected tree kind: " + packTree.getKind());
}
var actualJavadoc = trees.getDocComment(packPath);
var expectedJavadoc = "javadoc";
if (!expectedJavadoc.equals(actualJavadoc)) {
throw new AssertionError("Unexpected javadoc, " +
"expected: " + expectedJavadoc +
", got: " + actualJavadoc);
}
}
}
}
```
crashes with:
```
Exception running test testEmptyPackageInfo: java.lang.NullPointerException: Cannot invoke "com.sun.tools.javac.tree.JCTree.accept(com.sun.tools.javac.tree.JCTree$Visitor)" because "tree" is null
java.lang.NullPointerException: Cannot invoke "com.sun.tools.javac.tree.JCTree.accept(com.sun.tools.javac.tree.JCTree$Visitor)" because "tree" is null
at jdk.compiler/com.sun.tools.javac.tree.TreeInfo.declarationFor(TreeInfo.java:811)
at jdk.compiler/com.sun.tools.javac.model.JavacElements.getTreeAndTopLevel(JavacElements.java:779)
at jdk.compiler/com.sun.tools.javac.model.JavacElements.getTreeAndTopLevel(JavacElements.java:799)
at jdk.compiler/com.sun.tools.javac.api.JavacTrees.getPath(JavacTrees.java:331)
at jdk.compiler/com.sun.tools.javac.api.JavacTrees.getPath(JavacTrees.java:321)
at EmptyPackageInfo.testEmptyPackageInfo(EmptyPackageInfo.java:82)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:578)
at toolbox.TestRunner.runTests(TestRunner.java:89)
at EmptyPackageInfo.main(EmptyPackageInfo.java:49)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:578)
at java.base/java.lang.Thread.run(Thread.java:1623)
```
```
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* @test
* @bug 9999999
* @summary XXX
* @library /tools/lib
* @modules jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.main
* @build toolbox.TestRunner toolbox.ToolBox EmptyPackageInfo
* @run main EmptyPackageInfo
*/
import com.sun.source.tree.Tree;
import com.sun.source.util.JavacTask;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import com.sun.source.util.Trees;
import javax.tools.ToolProvider;
import toolbox.TestRunner;
import toolbox.TestRunner.Test;
import toolbox.ToolBox;
public class EmptyPackageInfo extends TestRunner {
public static void main(String... args) throws Exception {
new EmptyPackageInfo().runTests(m -> new Object[] { Paths.get(m.getName()) });
}
private final ToolBox tb = new ToolBox();
public EmptyPackageInfo() {
super(System.err);
}
@Test
public void testEmptyPackageInfo(Path outerBase) throws Exception {
Path src = outerBase.resolve("src");
Path classes = outerBase.resolve("classes");
Path packInfo = src.resolve("package-info.java");
tb.writeFile(packInfo, "/**javadoc*/\n");
Files.createDirectories(classes);
var compiler = ToolProvider.getSystemJavaCompiler();
try (var fm = compiler.getStandardFileManager(null,
null,
null)) {
var task =
(JavacTask) compiler.getTask(null,
fm,
null,
null,
null,
fm.getJavaFileObjects(packInfo));
task.analyze();
var pack = task.getElements().getPackageElement("");
var trees = Trees.instance(task);
var packPath = trees.getPath(pack);
var packTree = packPath.getLeaf();
if (packTree.getKind() != Tree.Kind.COMPILATION_UNIT) {
throw new AssertionError("Unexpected tree kind: " + packTree.getKind());
}
var actualJavadoc = trees.getDocComment(packPath);
var expectedJavadoc = "javadoc";
if (!expectedJavadoc.equals(actualJavadoc)) {
throw new AssertionError("Unexpected javadoc, " +
"expected: " + expectedJavadoc +
", got: " + actualJavadoc);
}
}
}
}
```
crashes with:
```
Exception running test testEmptyPackageInfo: java.lang.NullPointerException: Cannot invoke "com.sun.tools.javac.tree.JCTree.accept(com.sun.tools.javac.tree.JCTree$Visitor)" because "tree" is null
java.lang.NullPointerException: Cannot invoke "com.sun.tools.javac.tree.JCTree.accept(com.sun.tools.javac.tree.JCTree$Visitor)" because "tree" is null
at jdk.compiler/com.sun.tools.javac.tree.TreeInfo.declarationFor(TreeInfo.java:811)
at jdk.compiler/com.sun.tools.javac.model.JavacElements.getTreeAndTopLevel(JavacElements.java:779)
at jdk.compiler/com.sun.tools.javac.model.JavacElements.getTreeAndTopLevel(JavacElements.java:799)
at jdk.compiler/com.sun.tools.javac.api.JavacTrees.getPath(JavacTrees.java:331)
at jdk.compiler/com.sun.tools.javac.api.JavacTrees.getPath(JavacTrees.java:321)
at EmptyPackageInfo.testEmptyPackageInfo(EmptyPackageInfo.java:82)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:578)
at toolbox.TestRunner.runTests(TestRunner.java:89)
at EmptyPackageInfo.main(EmptyPackageInfo.java:49)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:578)
at java.base/java.lang.Thread.run(Thread.java:1623)
```
- backported by
-
JDK-8298957 Trees.getPath may crash for unnamed package
-
- Resolved
-