Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8299015

Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes

    XMLWordPrintable

Details

    • b03
    • Verified

    Backports

      Description

        The implementation of PathSubscriber should ensure that all bytes from the given buffers are written. Specifically, this method in PathSubscriber:

        @Override
        public void onNext(List<ByteBuffer> items) {
            try {
                out.write(items.toArray(Utils.EMPTY_BB_ARRAY));
        ...

        the implementation assumes out.write(ByteBuffer[]) always writes the content of all buffers - this isn't the case and the method can write a lesser number of bytes from input buffers.

        See https://mail.openjdk.org/pipermail/net-dev/2022-December/019883.html

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8299270 Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8299353 Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8313289 Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes

            • P3 - Major loss of function.
            • Resolved
            links to

            Commit Commit openjdk/jdk17u-dev/3ff9669b

            Commit Commit openjdk/jdk20/9863f59e

            Commit Commit openjdk/jdk/a7d6de71

            Review Review openjdk/jdk17u-dev/964

            Review Review openjdk/jdk20/70

            Review Review openjdk/jdk/11722

            Activity

              People

                chegar Chris Hegarty
                chegar Chris Hegarty
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: