Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8299254

Support dealing with standard assert macro

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 21
    • 11, 17, 21
    • hotspot
    • b05

    Description

      There are some places where we must deal with the conflict between HotSpot's assert macro and the standard assert macro. This can happen when including 3rd party headers (including standard library or os headers) in HotSpot code.

      The general approach to dealing with this is to ensure the HotSpot macro is not defined when including potentially problematic 3rd party headers, and reinstate the HotSpot macro after those includes.

      It would be helpful to have a utility for performing this dance, rather than recreating it multiple times.

      We should also arrange for -DNDEBUG to be defined in release builds to suppress the expansion of the standard assert macro.

      Attachments

        Issue Links

          duplicates

          Enhancement - null JDK-8299380 conflict assert definitions

          • P3 - Major loss of function.
          • Closed
          relates to

          Enhancement - null JDK-8321558 HotSpot Style Guide needs update regarding stdlib assert

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Enhancement - null JDK-8007770 fix name clash of assert macro in debug.hpp with libc's assert macro

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Enhancement - null JDK-8318078 ADLC: pass ASSERT and PRODUCT flags

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8299380 conflict assert definitions

          • P3 - Major loss of function.
          • Closed
          links to

          Commit Commit openjdk/jdk/3e2314d0

          Review Review openjdk/jdk11u-dev/2239

          Review Review openjdk/jdk17u-dev/1940

          Review Review openjdk/jdk/11770

          Activity

            People

              kbarrett Kim Barrett
              kbarrett Kim Barrett
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: