-
Enhancement
-
Resolution: Fixed
-
P4
-
None
-
b07
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8318275 | 17.0.10 | Goetz Lindenmaier | P4 | Resolved | Fixed | b01 |
JDK-8311673 | 17.0.9-oracle | Ramesh Gangadhar | P4 | Resolved | Fixed | b02 |
JDK-8318278 | 11.0.22 | Goetz Lindenmaier | P4 | Resolved | Fixed | b01 |
JDK-8311854 | 11.0.21-oracle | Ramesh Gangadhar | P4 | Resolved | Fixed | b02 |
- Some changes are made in the choice of algorithms and naming. The intent here is to reduce confusion and make the purpose of the test clearer:
- Updated the enabled digestAlgorithm in use from SHA1 to SHA256. The use of SHA1 here seems just a bit confusing, since it has been considered weak for a while
- The two different signer aliases are now named SIGNER1, SIGNER2 instead of the somewhat confusing SHA1, SHA256
- Both signing keys are now generated with -sigalg SHA256withRSA since the sigalg of the keys does not seem to matter for this test
There are also some general code cleanups:
- Moved loading of the key store into the new method loadKeyStore
- Updated checkThatJarIsSigned to take a parameter Map<String, Integer> representing the expected signer counts for each path in the JAR. This provides a cleaner separation between expectiations and the enforcement of expectations.
- Introduced Path constants for various file names used throughout the test, reducing a number of redundant Path.of calls which seemed to clutter the code a bit
Updated IO code to use new APIs, such as Files.newOutputStream, Files.newInputStream, InputStream.transferTo and OutputStream.nullOutputStream.
-Added/updated some comments where appropriate
- backported by
-
JDK-8311673 Improve readability of the test JarWithOneNonDisabledDigestAlg
- Resolved
-
JDK-8311854 Improve readability of the test JarWithOneNonDisabledDigestAlg
- Resolved
-
JDK-8318275 Improve readability of the test JarWithOneNonDisabledDigestAlg
- Resolved
-
JDK-8318278 Improve readability of the test JarWithOneNonDisabledDigestAlg
- Resolved
- links to
-
Commit openjdk/jdk11u-dev/9752bedf
-
Commit openjdk/jdk17u-dev/f7fb52b7
-
Commit openjdk/jdk/cf46004f
-
Review openjdk/jdk11u-dev/2182
-
Review openjdk/jdk17u-dev/1880
-
Review openjdk/jdk/11997