-
Bug
-
Resolution: Unresolved
-
P5
-
jfx20
Many of the comments in build.gradle are misleading because they are outdated or inaccurate. This can cause confusion to developers and should be cleaned up.
We can aggregate a list of such typos in this JBS issue.
1. https://github.com/openjdk/jfx/blob/21+0/build.gradle#L617
// Determine the verion of Java in JDK_HOME. It looks like this:
//
// $ java -version
// java version "1.7.0_45"
// Java(TM) SE Runtime Environment (build 1.7.0_45-b18)
// Java HotSpot(TM) 64-Bit Server VM (build 24.45-b08, mixed mode)
//
// We need to parse the second line
def inStream = new java.io.BufferedReader(new java.io.InputStreamReader(new java.lang.ProcessBuilder(JAVA, "-fullversion").start().getErrorStream()));
In addition to the typo on the first line above (verion instead of version), the command we actually run is "java -fullversion" not "java -version".
We can aggregate a list of such typos in this JBS issue.
1. https://github.com/openjdk/jfx/blob/21+0/build.gradle#L617
// Determine the verion of Java in JDK_HOME. It looks like this:
//
// $ java -version
// java version "1.7.0_45"
// Java(TM) SE Runtime Environment (build 1.7.0_45-b18)
// Java HotSpot(TM) 64-Bit Server VM (build 24.45-b08, mixed mode)
//
// We need to parse the second line
def inStream = new java.io.BufferedReader(new java.io.InputStreamReader(new java.lang.ProcessBuilder(JAVA, "-fullversion").start().getErrorStream()));
In addition to the typo on the first line above (verion instead of version), the command we actually run is "java -fullversion" not "java -version".
- blocks
-
JDK-8344728 ☂ Gradle build modernization
-
- Open
-