Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8302760

Improve liveness/remembered set verification for G1

XMLWordPrintable

    • gc
    • b11

      The liveness/remembered set verification code needs serious cleanup and improvements to robustness.

      - the previous potential separate use of liveness and remembered set verification made the code a bit more complicated than necessary; now that remembered set verification always follows liveness verification, the code can assume that.

      - lots of code duplication wrt to the code checking whether there were already enough failures to bail out

      - factored out a special `is_oop_safe` method that is particularly careful about accessing the klass of the potentially bad object

      - specialized the G1Mux2Closure in its single use to make the code clearer

      - removed lots of unused variables that were assigned once but never actually used

      - CollectedHeap::is_oop() should use `klass_raw` because otherwise it will immediately assert on oops with garbage klasses (but obviously still return `false` in this case).


            tschatzl Thomas Schatzl
            tschatzl Thomas Schatzl
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: