Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8303562

Remove obsolete comments in os::pd_attempt_reserve_memory_at

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 21
    • 21
    • hotspot
    • b13
    • generic
    • generic

      Some code comments become obsolete after JDK-8224871. We should remove them:

      ```
      diff --git a/src/hotspot/os/bsd/os_bsd.cpp b/src/hotspot/os/bsd/os_bsd.cpp
      index 144ca821307..c8af751250b 100644
      --- a/src/hotspot/os/bsd/os_bsd.cpp
      +++ b/src/hotspot/os/bsd/os_bsd.cpp
      @@ -1769,9 +1769,6 @@ char* os::pd_attempt_reserve_memory_at(char* requested_addr, size_t bytes, bool
         // in one of the methods further up the call chain. See bug 5044738.
         assert(bytes % os::vm_page_size() == 0, "reserving unexpected size block");

      - // Repeatedly allocate blocks until the block is allocated at the
      - // right spot.
      -
         // Bsd mmap allows caller to pass an address as hint; give it a try first,
         // if kernel honors the hint then we can return immediately.
         char * addr = anon_mmap(requested_addr, bytes, exec);
      diff --git a/src/hotspot/os/linux/os_linux.cpp b/src/hotspot/os/linux/os_linux.cpp
      index 42680218d8b..86de46df3d1 100644
      --- a/src/hotspot/os/linux/os_linux.cpp
      +++ b/src/hotspot/os/linux/os_linux.cpp
      @@ -4085,9 +4085,6 @@ char* os::pd_attempt_reserve_memory_at(char* requested_addr, size_t bytes, bool
         // in one of the methods further up the call chain. See bug 5044738.
         assert(bytes % os::vm_page_size() == 0, "reserving unexpected size block");

      - // Repeatedly allocate blocks until the block is allocated at the
      - // right spot.
      -
         // Linux mmap allows caller to pass an address as hint; give it a try first,
         // if kernel honors the hint then we can return immediately.
         char * addr = anon_mmap(requested_addr, bytes);
      ```

            fyang Fei Yang
            fyang Fei Yang
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: