Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8303937

Corrupted heap dumps due to missing retries for os::write()

    XMLWordPrintable

Details

    • 15
    • b14

    Backports

      Description

        After JDK-8237354, we noticed heap dumps could become corrupted.

        The root cause is in FileWriter::write_buf() in heapDumperCompression.cpp, for n = os::write(_fd, buf, (uint) size); n could be > 0 but smaller than size. In this case, there should be a loop to retry os::write() for the remaining bytes in buf. There was such a loop in DumpWriter::write_internal() before JDK-8237354.

        This problem is well documented in the man page for write(): https://man7.org/linux/man-pages/man2/write.2.html#RETURN_VALUE.

        In our case, we see the corruption frequently because we support dumping heap to a socket or pipe.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8304227 Corrupted heap dumps due to missing retries for os::write()

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8304233 Corrupted heap dumps due to missing retries for os::write()

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8304234 Corrupted heap dumps due to missing retries for os::write()

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8307012 Corrupted heap dumps due to missing retries for os::write()

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8310612 Corrupted heap dumps due to missing retries for os::write()

            • P3 - Major loss of function.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8303942 os::write should write completely

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8316468 os::write incorrectly handles partial write

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. JDK-8303943 jio_print doesn't allow for a short os::write

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Enhancement - null JDK-8237354 Add option to jcmd to write a gzipped heap dump

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/97809afd

            Commit Commit openjdk/jdk17u-dev/bc79161e

            Commit Commit openjdk/jdk20u/e7e1b5fd

            Commit Commit openjdk/jdk/bf16b5b9

            Review Review openjdk/jdk11u-dev/1801

            Review Review openjdk/jdk17u-dev/1201

            Review Review openjdk/jdk20u/18

            Review Review openjdk/jdk/12966

            Activity

              People

                manc Man Cao
                manc Man Cao
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: