Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8303951

Add asserts before record_method_not_compilable where possible

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 21
    • 21
    • hotspot
    • b16

      There are currently a few places where we simply bail out of C2 compilation. Some of them are justified. Others just encounter a bug, but bail out gracefully. This means we never catch those bugs.

      We should add an assert before record_method_not_compilable so that we can catch the bugs in debug build, but still handle it gracefully in production builds.

      One example is JDK-8303466. I had a IR test for a SuperWord regression test, but it would not compile. Finally, I found that it bailed out of compilation:
         4163 85 b 4 Test::test (32 bytes) COMPILE SKIPPED: malformed control flow (retry at different tier)

      But things like "malformed control flow" should be fixed. In this case, we have an IfNode that has only one output Projection.

        1. TestA.jasm
          0.7 kB

            epeter Emanuel Peter
            epeter Emanuel Peter
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: