Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8304014

Convert test/jdk/java/util/zip/ZipFile/CorruptedZipFiles.java to junit

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 21
    • 21
    • core-libs
    • None

      CorruptedZipFiles could benefit from some spring cleaning and a conversion to testNG:

      - The actual tests can be moved into their own @Test methods, given more meaningful names and a Javadoc comment explaining the constraint being verified
      - The setup code can be moved to a @Before method, slightly modernized and rewritten to take advantage of assertEquals
      checkZipExceptionImpl can be updated to take advantage of expectThrows
      - A bunch of constants copied over from ZipFile can be deleted since JDK-6225935 has long been fixed

            eirbjo Eirik Bjørsnøs
            eirbjo Eirik Bjørsnøs
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: