-
Enhancement
-
Resolution: Fixed
-
P4
-
21
-
None
-
b17
CorruptedZipFiles could benefit from some spring cleaning and a conversion to testNG:
- The actual tests can be moved into their own @Test methods, given more meaningful names and a Javadoc comment explaining the constraint being verified
- The setup code can be moved to a @Before method, slightly modernized and rewritten to take advantage of assertEquals
checkZipExceptionImpl can be updated to take advantage of expectThrows
- A bunch of constants copied over from ZipFile can be deleted sinceJDK-6225935 has long been fixed
- The actual tests can be moved into their own @Test methods, given more meaningful names and a Javadoc comment explaining the constraint being verified
- The setup code can be moved to a @Before method, slightly modernized and rewritten to take advantage of assertEquals
checkZipExceptionImpl can be updated to take advantage of expectThrows
- A bunch of constants copied over from ZipFile can be deleted since