-
Enhancement
-
Resolution: Fixed
-
P4
-
21, 22
-
b25
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8323572 | 21.0.3-oracle | Shivangi Gupta | P4 | Resolved | Fixed | b02 |
JDK-8324063 | 21.0.3 | Goetz Lindenmaier | P4 | Resolved | Fixed | b01 |
JDK-8340811 | 17.0.14 | Goetz Lindenmaier | P4 | Resolved | Fixed | b01 |
- The name 'TestTooManyEntries' does not clearly convey the purpose of the test. What is tested here is the validation that the total CEN size fits in a Java byte array. Suggested rename: CenSizeTooLarge
- The test creates DEFLATED entries which incurs zlib costs for no additional benefit. We can use STORED instead.
- The name of entries calls UUID.randomUUID, we could simply use a counter instead.
- The produced file is unnecessarily large. We know how large a CEN size is, let's take advantage of that to create a file with the minimal size.
- The summary and comments of the test can be improved to help explain the purpose of the test and how we reach the limit being tested.
- backported by
-
JDK-8323572 Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
- Resolved
-
JDK-8324063 Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
- Resolved
-
JDK-8340811 Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
- Resolved
- relates to
-
JDK-8304013 Add a fast, non-manual alternative to test/jdk/java/util/zip/ZipFile/TestTooManyEntries
- Resolved
- links to
-
Commit openjdk/jdk21u-dev/e3084fc3
-
Commit openjdk/jdk/f0b7eb51
-
Commit(master) openjdk/jdk17u-dev/ed2c4b68
-
Review openjdk/jdk21u-dev/172
-
Review openjdk/jdk/12991
-
Review(master) openjdk/jdk17u-dev/2913