Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8304020

Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose

    XMLWordPrintable

Details

    Backports

      Description

        TestTooManyEntries can be improved in the following ways:

        - The name 'TestTooManyEntries' does not clearly convey the purpose of the test. What is tested here is the validation that the total CEN size fits in a Java byte array. Suggested rename: CenSizeTooLarge

        - The test creates DEFLATED entries which incurs zlib costs for no additional benefit. We can use STORED instead.

        - The name of entries calls UUID.randomUUID, we could simply use a counter instead.

        - The produced file is unnecessarily large. We know how large a CEN size is, let's take advantage of that to create a file with the minimal size.

        - The summary and comments of the test can be improved to help explain the purpose of the test and how we reach the limit being tested.

        Attachments

          Issue Links

            Activity

              People

                eirbjo Eirik Bjørsnøs
                eirbjo Eirik Bjørsnøs
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: