Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8305063

Remove finalize() from HotSpot tests

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Delivered
    • Icon: P4 P4
    • tbd
    • 21
    • hotspot
    • Fix Understood
    • Verified

      In Hotspot tests, there are 148 cases of using finalize() method in 29 files as follows:-
      make test TEST=hotspot:tier1 JTREG="VERBOSE=summary"
      grep -rciH "\[removal\] finalize()" ./**/*.jtr | gawk '{split($0,a,":"); c = strtonum(a[2]); cnt += c; if (c != 0) print $0,"\t\t\t\t\t",cnt;} END {print cnt;} '

      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/c2/Test7190310.jtr:2
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/FindUniqueConcreteMethodTest.jtr:5
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/GetBytecodeTest.jtr:12
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/GetClassInitializerTest.jtr:4
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/GetImplementorTest.jtr:8
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/GetLineNumberTableTest.jtr:12
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/GetStackTraceElementTest.jtr:12
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/GetSymbolTest.jtr:2
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/GetVtableIndexForInterfaceTest.jtr:6
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/HasFinalizableSubclassTest.jtr:4
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/LookupKlassInPoolTest.jtr:4
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/LookupKlassRefIndexInPoolTest.jtr:4
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/LookupMethodInPoolTest.jtr:4
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/LookupNameAndTypeRefIndexInPoolTest.jtr:4
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/LookupNameInPoolTest.jtr:4
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/LookupSignatureInPoolTest.jtr:4
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/ResolveFieldInPoolTest.jtr:4
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/ResolveMethodTest.jtr:8
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/ResolvePossiblyCachedConstantInPoolTest.jtr:4
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/jvmci/compilerToVM/ResolveTypeInPoolTest.jtr:4
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/runtime/Test8168712_with-dtrace.jtr:1
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/compiler/runtime/Test8168712_without-dtrace.jtr:1
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/runtime/linkResolver/InterfaceObjectTest.jtr:1
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/serviceability/dcmd/framework/HelpTest.jtr:10
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/serviceability/dcmd/framework/InvalidCommandTest.jtr:10
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/serviceability/dcmd/framework/VMVersionTest.jtr:10
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/serviceability/dcmd/gc/FinalizerInfoTest.jtr:1
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/serviceability/dcmd/gc/RunFinalizationTest.jtr:1
      ./build/macosx-aarch64-debug/test-support/jtreg_test_hotspot_jtreg_tier1/serviceability/jvmti/RedefineClasses/RedefineFinalizer.jtr:2
      148

        1.
        		 Remove finalize() from compiler/c2/Test719030 Sub-task Resolved Afshin Zafari  
        2.
        		 Suppress the 'removal' warning for finalize() from test/hotspot/jtreg/compiler/jvmci/common/testcases that used in compiler/jvmci/compilerToVM/ tests Sub-task Resolved Afshin Zafari  
        3.
        		 Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712 Sub-task Resolved Afshin Zafari  
        4.
        		 Remove finalize() from test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java Sub-task Resolved Afshin Zafari  
        5.
        		 Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests Sub-task Resolved Afshin Zafari  
        6.
        		 Remove the removal warnings for finalize() from test/hotspot/jtreg/serviceability/dcmd/gc/FinalizerInfoTest.java and RunFinalizationTest.java Sub-task Resolved Afshin Zafari  
        7.
        		 Suppress removal warning for finalize() from test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineFinalizer.java Sub-task Resolved Afshin Zafari  

            azafari Afshin Zafari
            azafari Afshin Zafari
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: