Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8306467

Fix nsk/jdb/kill/kill001 to work with new JVMTI StopThread support for virtual threads.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P3 P3
    • 21
    • 21
    • core-svc
    • 21
    • b23

      Currently kill001 assumes that JVMTI StopThread (via JDI ThreadReference.stop) is not supported for virtual threads. JDK-8306034 is adding support for StopThread on a virtual thread as long as it is suspended and mounted. This means, for example, it will work for virtual threads in the following conditions:
      -Debuggee in a loop and suspended
      -Debuggee at a breakpoint and suspended

      But will continue to not work in the following situations:
      -Debuggee in a loop but not suspended
      -Debuggee suspended but unmounted, such as during a call the Thread.sleep()

      kill001 suspends all threads at a breakpoint and then does a "jdb kill" on each thread, which translate to ThreadReference.stop(), so this should be expected to work now.

      Most of the changes involve undoing the virtual thread specific code that was added to the test as part of JDK-8282385. However, there is an additional issue that also needs fixing. The test relies on the fact that the async exception is normally not caught, and that jdb normally stops when an uncaught exception is thrown. With virtual threads there ends up being an exception handler in java.lang.VirtualThread.run(), resulting in jdb not stopping when the async exception is thrown. This can be fixed by having the test issue a jdb "catch all <classname>" command for each async exception type that the test throws.

            cjplummer Chris Plummer
            cjplummer Chris Plummer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: