-
Enhancement
-
Resolution: Fixed
-
P4
-
21
-
b22
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8338131 | 17.0.13 | Amos SHI | P4 | Resolved | Fixed | b03 |
https://github.com/openjdk/jdk/blob/20b1d19d26a039b963590ca6f806f78a4a94c25f/test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchiveHeapTestClass.java#L160
mustFail(output, "Class pkg.ClassInPackage not allowed in archive heap");
However, the test case only checks for a non-zero exit code and the require error message. It missed the fact that the JVM has crashed. As a result,
It will be cumbersome to test for JVM crashing in every test case. Since most of CDS tests launch subprocesses using CDSTestUtils.executeAndLog, we can add the following check there:
if (output.getStdout().contains("https://bugreport.java.com/bugreport/crash.jsp")) {
throw new RuntimeException("Hotspot crashed");
}
- backported by
-
JDK-8338131 Add JVM crash check in CDSTestUtils.executeAndLog
- Resolved
- relates to
-
JDK-8306476 CDS ArchiveHeapTestClass.java test asserts when vm_exit is called on VM thread
- Resolved
-
JDK-8321933 TestCDSVMCrash.java spawns two processes
- Resolved
- links to
-
Commit openjdk/jdk/27764e60
-
Commit(master) openjdk/jdk17u-dev/a2b45f2e
-
Review openjdk/jdk/13817
-
Review(master) openjdk/jdk17u-dev/2771
(2 links to)