Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: P3
Fix Version/s: 21
Affects Version/s: 17, 20, 21
Component/s: hotspot
Labels:

Subcomponent:
runtime
Resolved In Build:
b21

Issue	Fix Version	Assignee	Priority	Status	Resolution	Resolved In Build
JDK-8308136	20u-cpu	Aleksey Shipilev	P3	Resolved	Fixed	master
JDK-8307391	20.0.2	Aleksey Shipilev	P3	Resolved	Fixed	b05
JDK-8316370	17.0.10-oracle	Calvin Cheung	P3	Resolved	Fixed	b01
JDK-8307562	17.0.8	Aleksey Shipilev	P3	Resolved	Fixed	b02

Found this mistake while backporting ~~JDK-8305994~~: if we put GADI=0 (defined as "disable guaranteed deflation"), then the MonitorDeflationThread would call `wait(0)`, that is, wait indefinitely for the notify. This breaks triggering the threshold heuristics!

But what is even more concerning, the same thing would happen even prior to ~~JDK-8305994~~, if we put GuaranteedSafepointInterval=0 too. Which means users who kept GSI=0 as the way to dodge excess safepoints, now effectively disable monitor deflation.

Draft: https://github.com/openjdk/jdk/pull/13635

backported by

JDK-8307391 Monitor deflation might be accidentally disabled by zero intervals

Resolved

JDK-8307562 Monitor deflation might be accidentally disabled by zero intervals

Resolved

JDK-8308136 Monitor deflation might be accidentally disabled by zero intervals

Resolved

JDK-8316370 Monitor deflation might be accidentally disabled by zero intervals

Resolved

relates to

JDK-8305994 Guarantee eventual async monitor deflation

Resolved

links to

Commit openjdk/jdk17u-dev/31bbf9f4

Commit openjdk/jdk20u/12d24f2f

Commit openjdk/jdk/a6b4f25b

Review openjdk/jdk17u-dev/1318

Review openjdk/jdk20u/71

Review openjdk/jdk/13635

(6 links to)

Assignee:: Aleksey Shipilev

Reporter:: Aleksey Shipilev

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 2023-04-25 02:52

Updated:: 2023-09-18 23:08

Resolved:: 2023-05-01 00:59

Details

Backports

Description

Attachments

Issue Links

Activity

People

Dates