-
Bug
-
Resolution: Fixed
-
P4
-
None
-
b10
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8322602 | 21.0.3 | Goetz Lindenmaier | P4 | Resolved | Fixed | b01 |
JDK-8341579 | 17.0.14 | Goetz Lindenmaier | P4 | Resolved | Fixed | b01 |
Using JStackStressTest.java as an example, we can see the problem here:
ProcessBuilder pb = new ProcessBuilder(JDKToolFinder.getTestJDKTool("jshell"));
jShellProcess = ProcessTools.startProcess("JShell", pb);
We should be using the JDKToolLauncher class. A working example can be found in ClhsdbLauncher.java:
JDKToolLauncher launcher = JDKToolLauncher.createUsingTestJDK("jhsdb");
launcher.addVMArgs(Utils.getTestJavaOpts());
launcher.addToolArg("clhsdb");
launcher.addToolArg("--core=" + coreFileName);
launcher.addToolArg("--exe=" + JDKToolFinder.getTestJDKTool("java"));
ProcessBuilder processBuilder = new ProcessBuilder(launcher.getCommand());
I think what will work for JStackStressTest.java is (this is completely untested):
JDKToolLauncher launcher = JDKToolLauncher.createUsingTestJDK("jshell");
launcher.addVMArgs(Utils.getTestJavaOpts());
ProcessBuilder pb = new ProcessBuilder(launcher.getCommand());
jShellProcess = ProcessTools.startProcess("JShell", pb);
This will get -XX:+UseZGC passed to the debuggee process. Note if there are any options we want filtered out, we can do something like the following:
launcher.addVMArgs(Utils.getFilteredTestJavaOpts("-Xcomp"));
- backported by
-
JDK-8322602 Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM
- Resolved
-
JDK-8341579 Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM
- Resolved
- relates to
-
JDK-8313655 sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java frequently fails with SerialGC
- Open
-
JDK-8313798 [aarch64] sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java sometimes times out on aarch64
- Resolved
- links to
-
Commit openjdk/jdk21u-dev/19d74b45
-
Commit openjdk/jdk/87b08b6e
-
Commit(master) openjdk/jdk17u-dev/74545e27
-
Review openjdk/jdk21u-dev/73
-
Review openjdk/jdk/15168
-
Review(master) openjdk/jdk17u-dev/2938