Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8309746

Reconfigure check should include make/conf/version-numbers.conf

    • b02

        When we bump the major JDK version, incremental builds break with errors like:

        java.lang.UnsupportedClassVersionError: java/lang/invoke/LambdaForm$DMH has been compiled by a more recent version of the Java Runtime (class file version 66.0), this version of the Java Runtime only recognizes class file versions up to 65.0

        This is rectified by rerunning configure. Init.gmk has a check to protect the user against such errors, but it currently only checks for changes in make/autoconf/*. We should add the relevant files in make/conf/*.conf to this list of dependencies. I believe the relevant files are version-numbers.conf and branding.conf based on which files are referenced from any .m4 files.

            [JDK-8309746] Reconfigure check should include make/conf/version-numbers.conf

            Fix Request (17u, 21u)

            Improves the build system resilience around configuration checks. Convenient to have when versions change for quarterly releases. Apply cleanly, with minor conflicts in copyright years in 17u. GHA tests pass.

            Aleksey Shipilev added a comment - Fix Request (17u, 21u) Improves the build system resilience around configuration checks. Convenient to have when versions change for quarterly releases. Apply cleanly, with minor conflicts in copyright years in 17u. GHA tests pass.

            Robo Duke added a comment -
            A pull request was submitted for review.
            URL: https://git.openjdk.org/jdk21u/pull/16
            Date: 2023-07-26 11:59:03 +0000

            Robo Duke added a comment - A pull request was submitted for review. URL: https://git.openjdk.org/jdk21u/pull/16 Date: 2023-07-26 11:59:03 +0000

            Robo Duke added a comment -
            A pull request was submitted for review.
            URL: https://git.openjdk.org/jdk17u-dev/pull/1626
            Date: 2023-07-26 11:53:38 +0000

            Robo Duke added a comment - A pull request was submitted for review. URL: https://git.openjdk.org/jdk17u-dev/pull/1626 Date: 2023-07-26 11:53:38 +0000

            Dukebot added a comment -
            Changeset: 955fc2fa
            Author: Erik Joelsson <erikj@openjdk.org>
            Date: 2023-06-14 13:27:19 +0000
            URL: https://git.openjdk.org/jdk/commit/955fc2fabafc4c4d79d137bf86194228d5cf8ad8

            Dukebot added a comment - Changeset: 955fc2fa Author: Erik Joelsson < erikj@openjdk.org > Date: 2023-06-14 13:27:19 +0000 URL: https://git.openjdk.org/jdk/commit/955fc2fabafc4c4d79d137bf86194228d5cf8ad8

            Robo Duke added a comment -
            A pull request was submitted for review.
            URL: https://git.openjdk.org/jdk/pull/14458
            Date: 2023-06-13 21:15:29 +0000

            Robo Duke added a comment - A pull request was submitted for review. URL: https://git.openjdk.org/jdk/pull/14458 Date: 2023-06-13 21:15:29 +0000

              erikj Erik Joelsson
              erikj Erik Joelsson
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: