Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8311545

Allow test symbol files to be kept in the test image

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 22
    • 22
    • infrastructure
    • None
    • b07

      It can be useful to have the symbol file(s) for a test present during execution - particularly those tests that involve crash reports or native stacks. Proposed fix:

      --- a/make/common/TestFilesCompilation.gmk
      +++ b/make/common/TestFilesCompilation.gmk
      @@ -106,7 +106,7 @@ define SetupTestFilesCompilationBody
               LIBS := $$($1_LIBS_$$(name)), \
               TOOLCHAIN := $(if $$(filter %.cpp, $$(file)), TOOLCHAIN_LINK_CXX, TOOLCHAIN_DEFAULT), \
               OPTIMIZATION := $$(if $$($1_OPTIMIZATION_$$(name)),$$($1_OPTIMIZATION_$$(name)),LOW), \
      - COPY_DEBUG_SYMBOLS := false, \
      + COPY_DEBUG_SYMBOLS := $$(if $$($1_COPY_DEBUG_SYMBOLS_$$(name)),$$($1_COPY_DEBUG_SYMBOLS_$$(name)),false), \
               STRIP_SYMBOLS := $$(if $$($1_STRIP_SYMBOLS_$$(name)),$$($1_STRIP_SYMBOLS_$$(name)),false), \
               BUILD_INFO_LOG_MACRO := LogInfo, \
           )) \

      this allows one to set e.g.

      BUILD_HOTSPOT_JTREG_LIBRARIES_COPY_DEBUG_SYMBOLS_libnativeStack := true

      in make/test/JtregNativeHotspot.gmk



            dholmes David Holmes
            dholmes David Holmes
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: