G1BarrierSet pre/post_barrier reaccess control instead of using argument

XMLWordPrintable

    • Type: Enhancement
    • Resolution: Unresolved
    • Priority: P4
    • tbd
    • Affects Version/s: 22
    • Component/s: hotspot

      The BarrierSet::{pre,post}_barrier functions take a "control" value as the second (ctl) argument. But for the G1 implementations at least (I've not looked at others) this argument is unused, with `__ ctrl()` being used instead. It seems like either the ctl argument isn't needed or it should be used instead of reaccessing. (I'm assuming the two expressions always provide the same value, else bad things can probably happen.)

            Assignee:
            Saranya Natarajan
            Reporter:
            Kim Barrett
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: