-
Enhancement
-
Resolution: Fixed
-
P4
-
21, 22, repo-lilliput-17
-
b16
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8317785 | 21.0.2 | Aleksey Shipilev | P4 | Resolved | Fixed | b03 |
These are the current names for the lightweight-locking functions:
AArch64, ppc, riscv: fast_lock
x86: fast_lock_impl
arm: fast_lock_2
Note that x86 and arm uses different names and the likely reason for that is that the C2_MacroAssembler subclass also implements a fast_lock function in that class, on those platforms.
The fast_lock function in C2_MacroAssembler deals with the fast locking for all LockingMode implementations (monitor, legacy, and lightweight), while the MacroAssembler::fast_lock* functions only implement the lightweight locking implementation.
I therefore propose that we use the name MacroAssembler::lightweight_lock on all platforms.
Note that this is a small cleanup to update the names. The reason why I'm looking into this is that I want to move the C2 fast locking code out of the AArch64 (and other platforms) .ad file into C++ files to make it consistent with the x64 code structure (and to get better IDE support when the code is in pure C++ files). That part will be handled as a separate PR.
- backported by
-
JDK-8317785 Use consistent naming for lightweight locking in MacroAssembler
-
- Resolved
-
- relates to
-
JDK-8316935 [s390x] Use consistent naming for lightweight locking in MacroAssembler
-
- Resolved
-
- links to
-
Commit openjdk/jdk21u/cbde98cb
-
Commit openjdk/jdk/639ba13c
-
Commit openjdk/lilliput-jdk17u/30596373
-
Review openjdk/jdk21u/220
-
Review openjdk/jdk/15709
-
Review openjdk/lilliput-jdk17u/66
-
Review openjdk/lilliput-jdk17u/69