Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8316702

Only evaluate buffer when IGVPrintLevelOption >= 5

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 22
    • 22
    • hotspot
    • b17
    • generic
    • generic

      We only emit IR per bytecode to IGV if the specified verbosity level is >=5.
      N=5: additionally, after parsing every bytecode (very slow)

      https://github.com/openjdk/jdk/blob/master/src/utils/IdealGraphVisualizer/README.md#usage

      I think we should match this in C2 Parse::do_one_bytecode().
      Currently, we conservatively check C->should_print_igv(1) and only emit IR per bytecode when level >= 5. It's wasteful for level>=1 and <= 4. we eval "jio_snprintf(buffer, sizeof(buffer), "Bytecode %d: %s", bci(), Bytecodes::name(bc()));' but emit nothing.

            xliu Xin Liu
            xliu Xin Liu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: