Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8317609

Classfile API fails to verify /jdk.jcmd/sun/tools/jstat/Alignment.class

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3
    • 22
    • 22
    • core-libs
    • b22
    • generic
    • linux
    • Verified

    Description

      This test:

      import java.nio.file.Path;
      import java.util.List;
      import java.util.ArrayList;
      import tests.JImageValidator;

      public class TestJImageValidator {
      public static void main(String[] args) throws Exception {
      Path p = Path.of(args[0]);
      Path modules = p.resolve("lib").resolve("modules");
      List<String> unexpected = List.of("/java/lang/String.class");
      List<String> expected = new ArrayList<>();
      JImageValidator.validate(modules, expected, unexpected);
      }
      }

      Using the JImageValidator from https://github.com/openjdk/jdk/blob/master/test/jdk/tools/lib/tests/JImageValidator.java and then running that test on a JDK including the jdk.jcmd module like so, produces the shown exception:

      java --add-opens=java.base/jdk.internal.jimage=ALL-UNNAMED --add-opens=java.base/jdk.internal.classfile=ALL-UNNAMED -cp build/linux-x86_64-server-fastdebug/test-support/jtreg_test_jdk_tools_jlink/classes/2/tools/lib:. TestJImageValidator ./build/jlink-jdk-jcmd
      java.lang.IllegalArgumentException: Could not resolve class Alignment
      at java.base/jdk.internal.classfile.impl.ClassHierarchyImpl.resolve(ClassHierarchyImpl.java:75)
      at java.base/jdk.internal.classfile.impl.ClassHierarchyImpl.isInterface(ClassHierarchyImpl.java:85)
      at java.base/jdk.internal.classfile.impl.verifier.VerificationType.resolve_and_check_assignability(VerificationType.java:384)
      at java.base/jdk.internal.classfile.impl.verifier.VerificationType.is_reference_assignable_from(VerificationType.java:404)
      at java.base/jdk.internal.classfile.impl.verifier.VerificationType._is_assignable_from(VerificationType.java:334)
      at java.base/jdk.internal.classfile.impl.verifier.VerificationType.is_assignable_from(VerificationType.java:309)
      at java.base/jdk.internal.classfile.impl.verifier.VerificationFrame.pop_stack(VerificationFrame.java:161)
      at java.base/jdk.internal.classfile.impl.verifier.VerifierImpl.verify_field_instructions(VerifierImpl.java:1475)
      at java.base/jdk.internal.classfile.impl.verifier.VerifierImpl.verify_method(VerifierImpl.java:1113)
      at java.base/jdk.internal.classfile.impl.verifier.VerifierImpl.verify_method(VerifierImpl.java:284)
      at java.base/jdk.internal.classfile.impl.verifier.VerifierImpl.verify_class(VerifierImpl.java:249)
      at java.base/jdk.internal.classfile.impl.verifier.VerifierImpl.verify(VerifierImpl.java:119)
      at java.base/jdk.internal.classfile.impl.verifier.VerifierImpl.verify(VerifierImpl.java:108)
      at java.base/jdk.internal.classfile.ClassModel.verify(ClassModel.java:86)
      at tests.JImageValidator.readClass(JImageValidator.java:225)
      at tests.JImageValidator.validate(JImageValidator.java:196)
      at TestJImageValidator.main(TestJImageValidator.java:12)
      /jdk.jcmd/sun/tools/jstat/Alignment.class ERROR java.io.IOException: java.lang.VerifyError: java.lang.IllegalArgumentException: Could not resolve class Alignment
      Exception in thread "main" java.io.IOException: java.lang.VerifyError: java.lang.IllegalArgumentException: Could not resolve class Alignment
      at tests.JImageValidator.readClass(JImageValidator.java:230)
      at tests.JImageValidator.validate(JImageValidator.java:196)
      at TestJImageValidator.main(TestJImageValidator.java:12)
      Caused by: java.lang.VerifyError: java.lang.IllegalArgumentException: Could not resolve class Alignment
      at java.base/jdk.internal.classfile.impl.verifier.VerifierImpl.verify_method(VerifierImpl.java:289)
      at java.base/jdk.internal.classfile.impl.verifier.VerifierImpl.verify_class(VerifierImpl.java:249)
      at java.base/jdk.internal.classfile.impl.verifier.VerifierImpl.verify(VerifierImpl.java:119)
      at java.base/jdk.internal.classfile.impl.verifier.VerifierImpl.verify(VerifierImpl.java:108)
      at java.base/jdk.internal.classfile.ClassModel.verify(ClassModel.java:86)
      at tests.JImageValidator.readClass(JImageValidator.java:225)
      ... 2 more

      The JDK image './build/jlink-jdk-jcmd' got produced with:
      $ jlink --add-modules jdk.jcmd --output ./build/jlink-jdk-jcmd

      Not sure what's wrong with the com.tools.jstat.Alignment.class to trigger this.

      Attachments

        Issue Links

          Activity

            People

              asotona Adam Sotona
              sgehwolf Severin Gehwolf
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: