Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8318455

Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java

    XMLWordPrintable

Details

    • b21
    • aarch64
    • linux

    Backports

      Description

        Said tests try to control the compilers used via arguments passed to subprocesses' they create. The JDK-8314838 added support for additional forwarding of the JTReg javaoptions to the subprocesses, but broke original arguments passing. They are now passed to the enclosing driver and simply ignored by ProcessTools.createTestJvm. We need to fix that.

        ==== Original description ===

        The following test failed in the JDK22 CI:

        compiler/sharedstubs/SharedTrampolineTest.java

        Here's a snippet from the log file:

        #section:driver
        ----------messages:(7/322)----------
        command: driver compiler.sharedstubs.SharedTrampolineTest -XX:-TieredCompilation
        reason: User specified action: run driver compiler.sharedstubs.SharedTrampolineTest -XX:-TieredCompilation
        started: Wed Oct 18 05:13:58 UTC 2023
        Mode: agentvm
        Agent id: 8
        finished: Wed Oct 18 05:13:58 UTC 2023
        elapsed time (seconds): 0.477
        ----------configuration:(14/1946)----------

        <snip>

        ----------System.out:(652/72127)----------
        Command line: [/opt/mach5/mesos/work_dir/jib-master/install/jdk-22+20-1558/linux-aarch64-debug.jdk/jdk-22/fastdebug/bin/java -cp /opt/mach5/mesos/work_dir/slaves/afbc6042-3a24-4198-9369-18c663a3f74c-S24959/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/5d1ce7d2-6bca-425c-b361-caf1f9b9c48e/runs/3d6b4ec7-b8cd-45f3-a366-a5c3551d72d2/testoutput/test-support/jtreg_open_test_hotspot_jtreg_hotspot_not_fast_compiler/classes/3/compiler/sharedstubs/SharedTrampolineTest.d:/opt/mach5/mesos/work_dir/jib-master/install/jdk-22+20-1558/src.full/open/test/hotspot/jtreg/compiler/sharedstubs:/opt/mach5/mesos/work_dir/slaves/afbc6042-3a24-4198-9369-18c663a3f74c-S24959/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/5d1ce7d2-6bca-425c-b361-caf1f9b9c48e/runs/3d6b4ec7-b8cd-45f3-a366-a5c3551d72d2/testoutput/test-support/jtreg_open_test_hotspot_jtreg_hotspot_not_fast_compiler/classes/3/test/lib:/opt/mach5/mesos/work_dir/jib-master/install/jtreg/7.3.1/1/bundles/jtreg-7.3.1+1.zip/jtreg/lib/jtreg.jar:/opt/mach5/mesos/work_dir/jib-master/install/jtreg/7.3.1/1/bundles/jtreg-7.3.1+1.zip/jtreg/lib/junit-platform-console-standalone-1.9.2.jar:/opt/mach5/mesos/work_dir/jib-master/install/jtreg/7.3.1/1/bundles/jtreg-7.3.1+1.zip/jtreg/lib/testng-7.3.0.jar:/opt/mach5/mesos/work_dir/jib-master/install/jtreg/7.3.1/1/bundles/jtreg-7.3.1+1.zip/jtreg/lib/jcommander-1.82.jar:/opt/mach5/mesos/work_dir/jib-master/install/jtreg/7.3.1/1/bundles/jtreg-7.3.1+1.zip/jtreg/lib/guice-5.1.0.jar -XX:MaxRAMPercentage=6.25 -Dtest.boot.jdk=/opt/mach5/mesos/work_dir/jib-master/install/jdk/21/35/bundles/linux-aarch64/jdk-21_linux-aarch64_bin.tar.gz/jdk-21 -Djava.io.tmpdir=/opt/mach5/mesos/work_dir/slaves/afbc6042-3a24-4198-9369-18c663a3f74c-S24959/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/5d1ce7d2-6bca-425c-b361-caf1f9b9c48e/runs/3d6b4ec7-b8cd-45f3-a366-a5c3551d72d2/testoutput/test-support/jtreg_open_test_hotspot_jtreg_hotspot_not_fast_compiler/tmp -XX:+UnlockDiagnosticVMOptions -XX:TieredStopAtLevel=3 -XX:+StressLoopInvariantCodeMotion -XX:+StressRangeCheckElimination -XX:+StressLinearScan -XX:+UnlockDiagnosticVMOptions -Xbatch -XX:+PrintRelocations -XX:CompileCommand=compileonly,compiler.sharedstubs.SharedTrampolineTest$StaticMethodTest::test -XX:CompileCommand=dontinline,compiler.sharedstubs.SharedTrampolineTest$StaticMethodTest::test -XX:CompileCommand=dontinline,compiler.sharedstubs.SharedTrampolineTest$StaticMethodTest::log compiler.sharedstubs.SharedTrampolineTest$StaticMethodTest a ]
        [2023-10-18T05:13:58.312009164Z] Gathering output for process 3702843
        [2023-10-18T05:13:58.319046034Z] Waiting for completion for process 3702843
        [2023-10-18T05:13:58.550224360Z] Waiting for completion finished for process 3702843
        CompileCommand: compileonly compiler/sharedstubs/SharedTrampolineTest$StaticMethodTest.test bool compileonly = true
        CompileCommand: dontinline compiler/sharedstubs/SharedTrampolineTest$StaticMethodTest.test bool dontinline = true
        CompileCommand: dontinline compiler/sharedstubs/SharedTrampolineTest$StaticMethodTest.log bool dontinline = true
        Compiled method (n/a) 103 1 n 0 java.lang.invoke.MethodHandle::linkToStatic(LLLLLL)L (native)
         total in heap [0x0000ffff6ccd1610,0x0000ffff6ccd1830] = 544
         relocation [0x0000ffff6ccd1778,0x0000ffff6ccd1798] = 32
         main code [0x0000ffff6ccd17c0,0x0000ffff6ccd182c] = 108
         stub code [0x0000ffff6ccd182c,0x0000ffff6ccd1830] = 4
        relocations:
                 @0x0000ffff6ccd1778: 7c04800d10c00000ffff3805
        relocInfo@0x0000ffff6ccd1782 [type=7(external_word) addr=0x0000ffff6ccd17d4 offset=20 data={800d10c00000ffff}] | [target=0x0000ffff800d10c0]
                 @0x0000ffff6ccd1784: 7c04800d10c00000ffff3805
        relocInfo@0x0000ffff6ccd178e [type=7(external_word) addr=0x0000ffff6ccd17e8 offset=20 data={800d10c00000ffff}] | [target=0x0000ffff800d10c0]
                 @0x0000ffff6ccd1790: 300e
        relocInfo@0x0000ffff6ccd1790 [type=6(runtime_call) addr=0x0000ffff6ccd1820 offset=56] | [destination=0x0000ffff6cb7bd40]
                 @0x0000ffff6ccd1792: 0000
        relocInfo@0x0000ffff6ccd1792 [type=0(none) addr=0x0000ffff6ccd1820 offset=0]
                 @0x0000ffff6ccd1794: 0000
        relocInfo@0x0000ffff6ccd1794 [type=0(none) addr=0x0000ffff6ccd1820 offset=0]
                 @0x0000ffff6ccd1796: 0000
        relocInfo@0x0000ffff6ccd1796 [type=0(none) addr=0x0000ffff6ccd1820 offset=0]
                 @0x0000ffff6ccd1798:
        - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

        <snip>

        relocInfo@0x0000ffff6ccdc0fa [type=12(metadata) addr=0x0000ffff6ccdd99c offset=4 data=33] | [metadata_addr=0x0000ffff6ccddb48 *=0x0000000000000000 offset=0]
                 @0x0000ffff6ccdc0fc: 300b
        relocInfo@0x0000ffff6ccdc0fc [type=6(runtime_call) addr=0x0000ffff6ccdd9c8 offset=44] | [destination=0x0000ffff6ccbf9c0]
                 @0x0000ffff6ccdc0fe: 3007
        relocInfo@0x0000ffff6ccdc0fe [type=6(runtime_call) addr=0x0000ffff6ccdd9e4 offset=28] | [destination=0x0000ffff6cc09e40]
                 @0x0000ffff6ccdc100:
        - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

        ----------System.err:(12/769)----------
        java.lang.RuntimeException: No runtime trampoline stubs reused: distinct 10, in total 10
        at compiler.sharedstubs.SharedTrampolineTest.checkOutput(SharedTrampolineTest.java:86)
        at compiler.sharedstubs.SharedTrampolineTest.runTest(SharedTrampolineTest.java:69)
        at compiler.sharedstubs.SharedTrampolineTest.main(SharedTrampolineTest.java:75)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333)
        at java.base/java.lang.Thread.run(Thread.java:1570)

        JavaTest Message: Test threw exception: java.lang.RuntimeException
        JavaTest Message: shutting down test

        result: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: No runtime trampoline stubs reused: distinct 10, in total 10

        Attachments

          Issue Links

            Activity

              People

                enikitin Evgeny Nikitin
                dcubed Daniel Daugherty
                Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: