Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8318480

Obsolete UseCounterDecay and remove CounterDecayMinIntervalLength

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 22
    • 17, 21, 22
    • hotspot
    • b25

    Description

      The UseCounterDecay and CounterDecayMinIntervalLength are not used.
      I can't find them in the code and can compile hotspot without them.
      They are still used in some tests though.

      See diff:
      15:30@home:~/ws/jdk/open(master)$
      ~>git diff
      diff --git a/src/hotspot/share/runtime/arguments.cpp b/src/hotspot/share/runtime/arguments.cpp
      index 1bdd20336ba..4e80a85dc4a 100644
      --- a/src/hotspot/share/runtime/arguments.cpp
      +++ b/src/hotspot/share/runtime/arguments.cpp
      @@ -3892,12 +3892,6 @@ jint Arguments::parse(const JavaVMInitArgs* initial_cmd_args) {
         if (TraceBytecodesAt != 0) {
           TraceBytecodes = true;
         }
      - if (CountCompiledCalls) {
      - if (UseCounterDecay) {
      - warning("UseCounterDecay disabled because CountCalls is set");
      - UseCounterDecay = false;
      - }
      - }
       #endif // PRODUCT
       
         if (ScavengeRootsInCode == 0) {
      diff --git a/src/hotspot/share/runtime/globals.hpp b/src/hotspot/share/runtime/globals.hpp
      index 4ae156a773e..edf8e428055 100644
      --- a/src/hotspot/share/runtime/globals.hpp
      +++ b/src/hotspot/share/runtime/globals.hpp
      @@ -1220,15 +1220,10 @@ const int ObjectAlignmentInBytes = 8;
         product(bool, UseCompiler, true, \
                 "Use Just-In-Time compilation") \
                                                                                   \
      - product(bool, UseCounterDecay, true, \
      - "Adjust recompilation counters") \
                                                                                   \
         develop(intx, CounterHalfLifeTime, 30, \
                 "Half-life time of invocation counters (in seconds)") \
                                                                                   \
      - develop(intx, CounterDecayMinIntervalLength, 500, \
      - "The minimum interval (in milliseconds) between invocation of " \
      - "CounterDecay") \
                                                                                   \
         product(bool, AlwaysCompileLoopMethods, false, \
                 "When using recompilation, never interpret methods " \

      Attachments

        Issue Links

          Activity

            People

              dlunden Daniel Lunden
              lmesnik Leonid Mesnik
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: