Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8318669

Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2

XMLWordPrintable

    • b21
    • windows

        In makefiles, we rely on statements like the following to determine if the target OS is Windows:
        ifeq ($(call isTargetOs, windows), true)
        ...

        When running the 'test-prebuilt' makefile target without explicitly specifying a value for OPENJDK_TARGET_OS, however, "ifeq ($(call isTargetOs, windows), true)" is only true when evaluated under Cygwin: when running on MSYS2 (or WSL), it will not be considered true, even though this would be the desired outcome.

        This situation is aggravated by the fact that Github Actions used for running prebuilt tests on Windows are run on MSYS2, without explicitly setting OPENJDK_TARGET_OS to "windows".

              fthevenet Frederic Thevenet
              fthevenet Frederic Thevenet
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: