Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8318953

RISC-V: Small refactoring for MacroAssembler::test_bit

    XMLWordPrintable

Details

    • b22
    • riscv
    • linux

    Backports

      Description

        The current test_bit assembly function needs to accept a temporary register because it needs one if it goes to the andi else branch. However, in this case we can actually avoid calling andi and accomplish the same thing by logically shifting to the right and testing the lowest bit. The advantage is that it makes the test_bit function much simpler. Also, to reduce the number of instructions in a given case (consider the mv function), mv actually calls the li function, which generates more than one instruction when the parameter imm exceeds the 32-bit range[1].
        [1] https://github.com/openjdk/jdk/blob/9123961aaa47aa58ec436640590d2cceedb8cbb1/src/hotspot/cpu/riscv/macroAssembler_riscv.cpp#L804-L840

        Attachments

          Issue Links

            Activity

              People

                gcao Gui Cao
                gcao Gui Cao
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: