Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8319301

Static analysis warnings after JDK-8318016

    XMLWordPrintable

Details

    • b25

    Description

      (just reporting the sightings, please rename this issue appropriately if this is a real problem).

      Sonar reports two new troubles in compileOracle.cpp:

      1) "left operand of '-' is a garbage value", when seeing that `line` might not be initialized properly:

        char* end;
        if (!parse_integer<size_t>(line, &end, &s)) {
          jio_snprintf(errorbuf, buf_size, "MemLimit: invalid value");
        }
        bytes_read = (int)(end - line); // <---- here

      2) "3rd function call argument is an uninitialized value", because there is an early `return true` from parseMemLimit that does not initialize `value`:

         // Special handling for memlimit
          bool success = (option == CompileCommand::MemLimit) && parseMemLimit(line, value, bytes_read, errorbuf, buf_size);
          if (!success) {
            // Is it a raw number?
            success = sscanf(line, "" INTX_FORMAT "%n", &value, &bytes_read) == 1;
          }
          if (success) {
            total_bytes_read += bytes_read;
            line += bytes_read;
            register_command(matcher, option, value); // <---- here

      Attachments

        Issue Links

          Activity

            People

              stuefe Thomas Stuefe
              shade Aleksey Shipilev
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: