Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8320363

ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity

    XMLWordPrintable

Details

    • b26
    • ppc

    Backports

      Description

        While looking at JDK-8261837, I noticed this ppc code:

            andi_(R0, klass, TypeEntries::type_unknown);
            // Already unknown. Nothing to do anymore.

        however, "klass" here should have all low bits set to 0. The code seems to need "tmp" here instead, which is the value from the profiling data slot.

        Failing this check looks mostly harmless, but it is a missed optimization.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8320812 ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8320966 ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8321160 ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/360bab8a

            Commit Commit openjdk/jdk17u-dev/8bf03b93

            Commit Commit openjdk/jdk21u/f8706d1d

            Commit Commit openjdk/jdk/6aa19766

            Review Review openjdk/jdk11u-dev/2310

            Review Review openjdk/jdk17u-dev/1989

            Review Review openjdk/jdk21u/403

            Review Review openjdk/jdk/16801

            Activity

              People

                mdoerr Martin Doerr
                dlong Dean Long
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: