Details
-
Enhancement
-
Resolution: Fixed
-
P4
-
22
-
b26
Backports
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8331779 | 21.0.5-oracle | Mimoun Ghordou | P4 | Resolved | Fixed | b01 |
JDK-8332444 | 21.0.4 | Andrew Lu | P4 | Resolved | Fixed | b04 |
Description
There are several areas where improvements can be made:
1. test should not exit early before all test cases have run.
2. some output hide the data details, which should be printed out to help debug any potential issues, e.g. currently it could output some log like below in case of wrong implementation of a ConvF2HF intrinsic:
`Inconsistent result for Float.floatToFloat16(NaN/ff802000): fc01 != fc01`, which is rather confusing, not helpful. Suggested output would be: `Inconsistent result for Float.floatToFloat16(NaN/ff802000): fc01(64513) != fc01(-1023)`
1. test should not exit early before all test cases have run.
2. some output hide the data details, which should be printed out to help debug any potential issues, e.g. currently it could output some log like below in case of wrong implementation of a ConvF2HF intrinsic:
`Inconsistent result for Float.floatToFloat16(NaN/ff802000): fc01 != fc01`, which is rather confusing, not helpful. Suggested output would be: `Inconsistent result for Float.floatToFloat16(NaN/ff802000): fc01(64513) != fc01(-1023)`
Attachments
Issue Links
- backported by
-
JDK-8331779 Improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16
-
- Resolved
-
-
JDK-8332444 Improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16
-
- Resolved
-
- relates to
-
JDK-8318228 RISC-V: C2 ConvF2HF
-
- Resolved
-
- links to
-
Commit openjdk/jdk21u-dev/2dc90b51
-
Commit openjdk/jdk/5dcf3a56
-
Review openjdk/jdk21u-dev/577
-
Review openjdk/jdk/16815
(2 links to)