Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8321596

Introduce a generic name for RestoreMXCSROnJNICalls

XMLWordPrintable

    • Icon: CSR CSR
    • Resolution: Unresolved
    • Icon: P4 P4
    • tbd
    • hotspot
    • None
    • minimal
    • This wouldn't break anything, but might confuse people looking for RestoreMXCSROnJNICalls.
    • add/remove/modify command line option
    • JDK

      Summary

      Replace the flag RestoreMXCSROnJNICalls by the more generic RestoreFPEnvOnJNICalls.

      Problem

      RestoreMXCSROnJNICalls is an x86-specific name for a generic need. It is to restore the floating-point control environment after a JNI call changed that environment.

      Solution

      Rename the current RestoreMXCSROnJNICalls to RestoreFPEnvOnJNICalls, changing its documentation string to make it non-x86-hardware specific without changing its usage in any way. An alternative would be non-generic names for each port.

      Specification

      Rename the flag, and introduce an alias in order to make sure existing scripts which use RestoreMXCSROnJNICalls continue to work. This alias does not need ever to expire.

      https://github.com/theRealAph/jdk/commit/550ce3c45b3ebe0179a5e23ee815c151e8b9915f

            aph Andrew Haley
            aph Andrew Haley
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: