Loading...

XML

Word

Printable

Type: Enhancement
Resolution: Fixed
Priority: P4
Fix Version/s: 23
Affects Version/s: 17, 21, 22, 23
Component/s: hotspot
Labels:

Subcomponent:
compiler
Resolved In Build:
b05

Issue	Fix Version	Assignee	Priority	Status	Resolution	Resolved In Build
JDK-8323734	22.0.1	Aleksey Shipilev	P4	Resolved	Fixed	b02
JDK-8326507	21.0.4-oracle	Tobias Hartmann	P4	Resolved	Fixed	b01
JDK-8323750	21.0.3	Aleksey Shipilev	P4	Resolved	Fixed	b01

I was looking at hotpath for IC stub cleaning (happens at safepoint), and one obvious thing is that we look-up `CodeBlob` from `call->instruction_address()` only to assert that is compiled one. It used to be protected by `#ifdef ASSERT` before ~~JDK-8212681~~, and pulled from it to be used in Mutex:
https://hg.openjdk.org/jdk/jdk/rev/d6dc479bcdd3#l15.62

...which is now gone after ~~JDK-8214257~~.

backported by

JDK-8323734 Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination

Resolved

JDK-8323750 Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination

Resolved

JDK-8326507 Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination

Resolved

relates to

JDK-8214257 IC cache not clean after cleaning assertion failure

Closed

JDK-8212681 Refactor IC locking to use a fine grained CompiledICLocker

Resolved

links to

Commit openjdk/jdk21u-dev/1b5aeb92

Commit openjdk/jdk22u/dfce95ad

Commit openjdk/jdk/eb9e754b

Review openjdk/jdk21u-dev/151

Review openjdk/jdk22u/14

Review openjdk/jdk/17281

(6 links to)

Assignee:: Aleksey Shipilev

Reporter:: Aleksey Shipilev

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 2024-01-05 06:33

Updated:: 2024-02-22 07:59

Resolved:: 2024-01-08 02:30

Details

Backports

Description

Attachments

Issue Links

Activity

People

Dates