[GenShen] Alloca avoidance, const-safety, interface decluttering in promotion budgeting

In code related to the computation of promotion budgets and region preselection for promotion:

1. avoid alloca, instead encapsulating region preselection using RAII pattern
2. const-safety and some additional asserts related to 1
3. declutter some method interfaces
4. expand some documentation comments