Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8323169

j2dbench need constant updating of javac source/target

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Unresolved
    • P4
    • tbd
    • 21
    • client-libs
    • None
    • 2d

    Description

      j2dbench makefile, build.xml and redme have weird likness of old bytecode, and with each LTS, someting like:

      {code:java}
      diff --git a/src/demo/share/java2d/J2DBench/Makefile b/src/demo/share/java2d/J2DBench/Makefile
      index 04b0818a2c3..eacb87d5e26 100644
      --- a/src/demo/share/java2d/J2DBench/Makefile
      +++ b/src/demo/share/java2d/J2DBench/Makefile
      @@ -120,7 +120,7 @@ $(CLASSES):
       mkdirs: $(DIST) $(CLASSES)
       
       $(CLASSES)/j2dbench/%.class: $(SOURCEPATH)/j2dbench/%.java
      - javac -g:none -source 1.7 -target 1.7 -d $(CLASSES) -sourcepath $(SOURCEPATH) $<
      + javac -g:none -source 9 -target 9 -d $(CLASSES) -sourcepath $(SOURCEPATH) $<
       
       clean:
              rm -rf $(CLASSES)
      diff --git a/src/demo/share/java2d/J2DBench/README b/src/demo/share/java2d/J2DBench/README
      index 3b9f25c13f1..af760c1bc97 100644
      --- a/src/demo/share/java2d/J2DBench/README
      +++ b/src/demo/share/java2d/J2DBench/README
      @@ -20,8 +20,8 @@ Minimum requirements
       -----------------------------------------------------------------------
       
       The benchmark requires at least jdk1.4 to compile and run. Note that
      -source/target is set to 1.7 in the makefile and build.xml, because of
      -support in jdk 14 compiler. To check compatibility with jdk1.4 you can
      +source/target is set to 9 in the makefile and build.xml, because of
      +support in jdk 22 compiler. To check compatibility with jdk1.4 you can
       use "-source 1.4 -target 1.4" options and jdk1.7.
       
       -----------------------------------------------------------------------
      diff --git a/src/demo/share/java2d/J2DBench/build.xml b/src/demo/share/java2d/J2DBench/build.xml
      index 7b202946cf1..d2c642e8928 100644
      --- a/src/demo/share/java2d/J2DBench/build.xml
      +++ b/src/demo/share/java2d/J2DBench/build.xml
      @@ -49,7 +49,7 @@
         <target name="compile" depends="init"
               description="compile the source " >
           <!-- Compile the java code from ${src} into ${build} -->
      - <javac debug="off" source="1.7" target="1.7" srcdir="${src}" destdir="${build}"/>
      + <javac debug="off" source="9" target="9" srcdir="${src}" destdir="${build}"/>
         </target>
       
         <target name="run" depends="dist">
      {code}

      is needed.

      As the j2dbench is nearly always run against the jdk it is part of, or at elast against jdk it was build with, I would like to suggest the removal of any {{source/target}} occurrences from j2dbench

      Currently when compiled by jdk21 there is about 50 warnings based on deprecation. Those should be fixed to.

      Attachments

        Activity

          People

            jvanek Jiří Vaněk
            jvanek Jiří Vaněk
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: