In globalDefinitions_visCPP.hpp there is a redefinition of NULL to work around an issue with it being a 32bit int (so not pointer sized) on 64bit platforms. Once all uses of NULL in HotSpot have been replaced with nullptr, there is no longer any need for this, and it can be removed.
One might think that redefinition might no longer be needed at all, since it's working around a pretty old issue. But apparently it's still the case that sizeof(NULL) != sizeof(void*) for 64bit builds. But a literal 0 (a 32bit int) is a valid null pointer constant.
One might think that redefinition might no longer be needed at all, since it's working around a pretty old issue. But apparently it's still the case that sizeof(NULL) != sizeof(void*) for 64bit builds. But a literal 0 (a 32bit int) is a valid null pointer constant.
- is blocked by
-
JDK-8324679 Replace NULL with nullptr in HotSpot .ad files
- Resolved
- relates to
-
JDK-8343802 Prevent NULL usage backsliding
- Open
-
JDK-8299837 Replace NULL with nullptr in hotspot code and tests
- Closed